feat: add flowsheet entry_type discriminated union with V2 API #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebromberg
force-pushed
the
feature/flowsheet-entry-type-discriminated-union
branch
3 times, most recently
from
782a2a3 to
cc1136e
Compare
jakebromberg
force-pushed
the
feature/flowsheet-entry-type-discriminated-union
branch
from
cc1136e to
262b1fe
Compare
jakebromberg
force-pushed
the
feature/flowsheet-entry-type-discriminated-union
branch
2 times, most recently
from
917a948 to
305797d
Compare
added 3 commits
January 31, 2026 05:03
Add explicit entry_type field to flowsheet entries, enabling cleaner API responses and type-safe client code. Maintains V1 compatibility while providing a new V2 API with discriminated union responses. Database changes: - Add flowsheet_entry_type enum (track, show_start, show_end, dj_join, dj_leave, talkset, breakpoint, message) - Add entry_type column with migration and backfill - Add index for filtering by entry_type V2 API endpoints: - GET /v2/flowsheet - Returns discriminated union format - POST /v2/flowsheet/track - Add track entry - POST /v2/flowsheet/talkset - Add talkset entry - POST /v2/flowsheet/breakpoint - Add breakpoint entry - POST /v2/flowsheet/message - Add custom message - PATCH/DELETE /v2/flowsheet/:id - Update/delete by path param Tests: - 23 unit tests for transformToV2() function - ~350 lines of V2 API integration tests
jakebromberg
force-pushed
the
feature/flowsheet-entry-type-discriminated-union
branch
from
b524661 to
61980f1
Compare
Add entry_type to FSEntryRaw type and transformToIFSEntry function so that GET /flowsheet returns the entry_type field as expected.
The /request route was missing after rebase onto main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit
entry_typediscriminated union to flowsheet entries in the database, with V1 API compatibility and a V2 playlist endpoint for clean discriminated union responses.Entry Types
trackshow_startshow_enddj_joindj_leavetalksetbreakpointmessageDatabase Changes
flowsheet_entry_typeenumentry_typecolumn with migration and backfillAPI Changes
V1 API - Additive change only:
entry_typefieldV2 API - Single endpoint:
V1 vs V2 Playlist Response
V1
/flowsheet/playlist: entries include all fields{ "entries": [{ "id": 123, "entry_type": "track", "artist_name": "Built to Spill", "message": null, ... }] }V2
/v2/flowsheet/playlist: entries use clean discriminated union (no irrelevant fields){ "entries": [{ "id": 123, "entry_type": "track", "artist_name": "Built to Spill", ... }] }Test plan
transformToV2()functionentry_typecompatibility testSELECT entry_type, COUNT(*) FROM flowsheet GROUP BY entry_type